Skip to content

[Qt] fix style, formating, comment and indentation problems#3923

Merged
laanwj merged 1 commit intobitcoin:masterfrom
Diapolo:fix_garbage
Mar 27, 2014
Merged

[Qt] fix style, formating, comment and indentation problems#3923
laanwj merged 1 commit intobitcoin:masterfrom
Diapolo:fix_garbage

Conversation

@Diapolo
Copy link
Copy Markdown

@Diapolo Diapolo commented Mar 21, 2014

@Diapolo
Copy link
Copy Markdown
Author

Diapolo commented Mar 27, 2014

@laanwj Can you please take a look and merge this, I have less motivation currently, as my old pulls seem all to be just ignored, even ones that are ACKd already.

See #3698, #3682 or #3603...

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Mar 27, 2014

@Diapolo Sorry, seems those got stuck.
(for core pull requests I wait for more ACKs, not just mine, but if it's a trivial style fix it shouldn't have to wait that long...)
We really, really need more people that do code review/testing...

@BitcoinPullTester
Copy link
Copy Markdown

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/cfe4cad9e5ad040a1dbfc14098628fa30aa87498 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

laanwj added a commit that referenced this pull request Mar 27, 2014
cfe4cad [Qt] fix style, formating, comment and indentation problems (Philip Kaufmann)
@laanwj laanwj merged commit cfe4cad into bitcoin:master Mar 27, 2014
@Diapolo Diapolo deleted the fix_garbage branch March 27, 2014 10:24
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants