Skip to content

remove unused code from getblockchaininfo()#4328

Merged
laanwj merged 1 commit intobitcoin:masterfrom
Diapolo:rem_dead_code
Jun 11, 2014
Merged

remove unused code from getblockchaininfo()#4328
laanwj merged 1 commit intobitcoin:masterfrom
Diapolo:rem_dead_code

Conversation

@Diapolo
Copy link
Copy Markdown

@Diapolo Diapolo commented Jun 11, 2014

No description provided.

@BitcoinPullTester
Copy link
Copy Markdown

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/f3790472f0efca258670342050801ec17c1bb1bb for binaries and test log.

This could happen for one of several reasons:

  1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
  2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
  3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
  4. The test suite fails on either Linux i386 or Win32
  5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@laanwj laanwj merged commit f379047 into bitcoin:master Jun 11, 2014
laanwj added a commit that referenced this pull request Jun 11, 2014
f379047 remove unused code from getblockchaininfo() (Philip Kaufmann)
@Diapolo Diapolo deleted the rem_dead_code branch June 12, 2014 06:34
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants