Skip to content

qt: Always log warning/error messages to debug.log#4448

Merged
gavinandresen merged 2 commits intobitcoin:masterfrom
laanwj:2014_07_qt_payment_rq_logging
Jul 1, 2014
Merged

qt: Always log warning/error messages to debug.log#4448
gavinandresen merged 2 commits intobitcoin:masterfrom
laanwj:2014_07_qt_payment_rq_logging

Conversation

@laanwj
Copy link
Copy Markdown
Member

@laanwj laanwj commented Jul 1, 2014

Make sure important messages aren't thrown away.

  • Log messages with type>QtDebugMsg as non-debug
  • Change serious messages from qDebug to qWarning

Keep just-for-info messages at qDebug, those can still be activated with -debug=qt.

laanwj added 2 commits July 1, 2014 14:58
More important messages should end up in the log no matter
if -debug=qt is set.
By changing the logging stream for warnings from qDebug to qWarning,
these will always be logged to debug.log.
@BitcoinPullTester
Copy link
Copy Markdown

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4448_33fdd99288fd257d6b5a3797a0a68aff649a3a71/ for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@gavinandresen
Copy link
Copy Markdown
Contributor

Nice.

gavinandresen added a commit that referenced this pull request Jul 1, 2014
qt: Always log warning/error messages to debug.log
@gavinandresen gavinandresen merged commit f04f123 into bitcoin:master Jul 1, 2014
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants