Spanish translation update#504
Conversation
|
ACK |
|
Can you remove the binary mo file? |
|
eh ? dunno how it shows up but the binary has been deleted |
|
Oh, you deleted it, my bad. |
|
np :) |
|
The commit deletes *.mo, which is not the desired effect. Your commit needs to simply modify *.po, and touch nothing else. Thanks. |
|
yeah, that would be my goal in every commit but with this one i had some troubles cause the editor overwrites the *.mo at the same time when you save the translation. I didn't know it was this difficult for you guys to manage submitted work from other people, i will try not to bother again. Thanks |
|
It becomes difficult for the very few engineers with pull requests, if each pull request requires manual modification after it is submitted. It is -normal- in an open source project to request the submittor update their pull request in response to feedback. See the Linux kernel, or Apache, or Eclipse, or any number of other open source projects for similar feedback-response-update workflow. Only by working together, through a normal conversation with feedback and response, do open source projects succeed. |
|
thanks jgarzik for taking your time to explain this issue, i do not fully agree here but will not continue with probably already answered questions. A "committer guide" will be nice though to maintain some order and less troubles for the main devel :) I'm not experienced with git so i will be redoing all the forking and committing stuff to fully comply, doing your work harder was not my intention. |
[ported] Core PR 8070 and PR 7932
Routing - Typos
New wallet encryption + small fixes