Skip to content

Spanish translation update#504

Closed
paraipan wants to merge 1 commit intobitcoin:masterfrom
paraipan:master
Closed

Spanish translation update#504
paraipan wants to merge 1 commit intobitcoin:masterfrom
paraipan:master

Conversation

@paraipan
Copy link
Copy Markdown
Contributor

@paraipan paraipan commented Sep 6, 2011

New wallet encryption + small fixes

@alexwaters
Copy link
Copy Markdown
Contributor

ACK

@TheBlueMatt
Copy link
Copy Markdown
Contributor

Can you remove the binary mo file?

@paraipan
Copy link
Copy Markdown
Contributor Author

paraipan commented Sep 6, 2011

eh ? dunno how it shows up but the binary has been deleted

@TheBlueMatt
Copy link
Copy Markdown
Contributor

Oh, you deleted it, my bad.
I thought it had been modified.
ACK

@paraipan
Copy link
Copy Markdown
Contributor Author

paraipan commented Sep 7, 2011

np :)

@jgarzik
Copy link
Copy Markdown
Contributor

jgarzik commented Sep 11, 2011

The commit deletes *.mo, which is not the desired effect.

Your commit needs to simply modify *.po, and touch nothing else.

Thanks.

@paraipan
Copy link
Copy Markdown
Contributor Author

yeah, that would be my goal in every commit but with this one i had some troubles cause the editor overwrites the *.mo at the same time when you save the translation. I didn't know it was this difficult for you guys to manage submitted work from other people, i will try not to bother again. Thanks

@jgarzik
Copy link
Copy Markdown
Contributor

jgarzik commented Sep 11, 2011

It becomes difficult for the very few engineers with pull requests, if each pull request requires manual modification after it is submitted.

It is -normal- in an open source project to request the submittor update their pull request in response to feedback. See the Linux kernel, or Apache, or Eclipse, or any number of other open source projects for similar feedback-response-update workflow.

Only by working together, through a normal conversation with feedback and response, do open source projects succeed.

@paraipan
Copy link
Copy Markdown
Contributor Author

thanks jgarzik for taking your time to explain this issue, i do not fully agree here but will not continue with probably already answered questions. A "committer guide" will be nice though to maintain some order and less troubles for the main devel :)

I'm not experienced with git so i will be redoing all the forking and committing stuff to fully comply, doing your work harder was not my intention.

@paraipan paraipan closed this Sep 11, 2011
ptschip pushed a commit to ptschip/bitcoin that referenced this pull request May 2, 2017
rajarshimaitra pushed a commit to rajarshimaitra/bitcoin that referenced this pull request Aug 5, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
@maflcko maflcko removed the CI failed label Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants