Skip to content

Update the intent on SI-style separators.#5388

Merged
laanwj merged 1 commit intomasterfrom
unknown repository
Dec 1, 2014
Merged

Update the intent on SI-style separators.#5388
laanwj merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Nov 28, 2014

Clean up of #5372

Comment thread src/qt/bitcoinunits.cpp Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be SI-style instead of SI-stule?

@laanwj laanwj added the Docs label Nov 28, 2014
@ghost
Copy link
Copy Markdown
Author

ghost commented Nov 28, 2014

Fixed both typos, "SI-stule" and "indendent".

@sipa
Copy link
Copy Markdown
Member

sipa commented Nov 28, 2014

I'm confused. I thought the small-spaces-separators thing got reverted? (no opinion either way here; just asking what this is about...)

@ghost
Copy link
Copy Markdown
Author

ghost commented Nov 28, 2014

Apparently thin spaces are still alive and kicking, but only to the left of the decimal marker, and regardless of the number of digits involved in the quotient (of course greater than 3 that is, but not 4). So this commit is no more but the code comment catching up with the code. The code rationale itself is covered by Wladimir in #5372.

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Dec 1, 2014

Only separators to the right of the decimal point were reverted. IMO as non-physicist it was too hard to get used to digit grouping after the point.

@laanwj laanwj merged commit 1cf23f6 into bitcoin:master Dec 1, 2014
laanwj added a commit that referenced this pull request Dec 1, 2014
1cf23f6 Update the intent on SI-style separators. (21E14)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants