Skip to content

[Qt] light blue icon color for regtest#5488

Merged
laanwj merged 1 commit intobitcoin:masterfrom
jonasschnelli:2014_12_regtest_icon
Dec 16, 2014
Merged

[Qt] light blue icon color for regtest#5488
laanwj merged 1 commit intobitcoin:masterfrom
jonasschnelli:2014_12_regtest_icon

Conversation

@jonasschnelli
Copy link
Copy Markdown
Contributor

Changing the icons color for regtest in now lightweight.

Changing the icons color for regtest in now lightweight.
@jonasschnelli
Copy link
Copy Markdown
Contributor Author

example:

bildschirmfoto 2014-12-16 um 13 36 43

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Dec 16, 2014

Nice :-) All that by changing one number.

@fanquake
Copy link
Copy Markdown
Member

Tested ACK

@laanwj laanwj merged commit ff63801 into bitcoin:master Dec 16, 2014
laanwj added a commit that referenced this pull request Dec 16, 2014
ff63801 [Qt] light blue icon color for regtest (Jonas Schnelli)
@paveljanik
Copy link
Copy Markdown
Contributor

Now, I see this warning at the start of bitcoin-qt:

libpng warning: iCCP: known incorrect sRGB profile

I like the solution though :-) There is some guide to fix at https://wiki.archlinux.org/index.php/Libpng_errors

@jonasschnelli
Copy link
Copy Markdown
Contributor Author

@paveljanik i think we must take this upstream to the Qt team. It seems to be a Qt issue? Or what do you think?

@paveljanik
Copy link
Copy Markdown
Contributor

According to notes on the Internet, you can run

convert -stripe

on the image. The question is, if the profile is not added by your changes...

@jonasschnelli
Copy link
Copy Markdown
Contributor Author

@paveljanik the issue you reporting is not related to this pull (because this pull did not change and bitmap files). I'll have a look at the sRGB profile issue.

@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Dec 16, 2014

Merged too quick... I was going to shed-paint that I liked the green! :p jk

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants