Reduce boost namespace pollution#5513
Merged
laanwj merged 3 commits intobitcoin:masterfrom Jan 6, 2015
Merged
Conversation
|
I really like the first and the last commit, they look good to me. I personally would reject the middle commit that touches the unit test (see comment there). |
Contributor
|
IMO: this makes the code more readable and i also see this as a good practice. |
Member
|
Looks good to me. I'm not a big fan of 'using namespace XXX' on a global level either. If it makes things too wordy you can always use them at a function level. Needs rebase though. |
Member
Author
|
rebased |
Standard functions are even simpler
A few boost::asio were left around because they're very wordy otherwise.
Member
|
Untested ACK. @zander Your comment on the second commit is lost due to the rebase. |
Member
Author
|
Pre-rebase comments can be seen here: |
Member
|
ACK, no binary changes in bitcoind |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #3483, as well as being a good practice in general. The second commit changes a bit of code, so it's not lumped in with the rest. The others should be semantic changes only.
After this, there are only 2 users of "using namespace boost::foo" left, and those were left in because they're very wordy otherwise.