Merged
Conversation
Contributor
|
Tested ACK: more tests is good. RE: having a 2-of-3 count as spendable: WAAAY back when I implemented P2SH support to the wallet I decided that the safest thing to do would be to only count as spendable outputs for which you had ALL of the keys. The double-spend / conflicting transaction code is much better now, so I'm not worried any more, and would be in favor of changing to counting any output for which you have enough keys to fully sign count as spendable (assuming we have good regression tests like this one to go along with that change, of course). |
Contributor
|
ut ACK |
jonasschnelli
force-pushed
the
2015/04/multisig_rpc_tests
branch
from
a96e3bc to
0b3c554
Compare
Contributor
Author
|
Rebased and adapted |
jonasschnelli
force-pushed
the
2015/04/multisig_rpc_tests
branch
3 times, most recently
from
71cec13 to
1f5edf1
Compare
Contributor
|
utACK. Please fix the typo in the commit message (mutlisig). |
jonasschnelli
force-pushed
the
2015/04/multisig_rpc_tests
branch
from
1f5edf1 to
231072f
Compare
Contributor
Author
|
@paveljanik: fixed. Thanks @paveljanik! |
laanwj
added a commit
that referenced
this pull request
May 7, 2015
231072f [QA] add multisig rpc tests (Jonas Schnelli)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrote this during some educational tests. Could also be useful for others trying to get more into multisig.
And tests will always help to improve maintainability.