Improving labels for Sent / Received "Bytes"#6940
Merged
laanwj merged 1 commit intobitcoin:masterfrom Nov 10, 2015
jonathancross:patch-1
Merged
Improving labels for Sent / Received "Bytes"#6940laanwj merged 1 commit intobitcoin:masterfrom jonathancross:patch-1
laanwj merged 1 commit intobitcoin:masterfrom
jonathancross:patch-1
Conversation
The labels for Sent & Received data in the "Peers" debug panel should not be defined as "Bytes" because the units (B, KB, MB) appear after the number. I decided to simply use "Sent" and "Received" (rather than "Data Sent" and "Data Received") because we already have translations for the former: https://www.transifex.com/bitcoin/bitcoin/viewstrings/#ja/qt-translation-011x/47533089?q=sent https://www.transifex.com/bitcoin/bitcoin/viewstrings/#ja/qt-translation-011x/47533089?q=received Demo of changes: Current UI: Bytes Sent 12 KB Bytes Received 26 MB With this pull request: Sent 12 KB Received 26 MB
Contributor
|
|
Member
Still, I'd prefer "Data *" or just keep "Bytes *" because you can also send packets or messages or... |
Member
|
I'm ok with this change, "bytes" is indeed redundant, the unit speaks for itself. |
laanwj
added a commit
that referenced
this pull request
Nov 10, 2015
7ca73dc Improving labels for Sent / Received "Bytes" (Jonathan Cross)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The labels for Sent & Received data in the "Peers" debug panel should not be defined as "Bytes" because the units (
B,KB,MB) appear after the number making this redundant. I decided to simply use "Sent" and "Received" (rather than "Data Sent" and "Data Received") because we already have translations for the former.Japanese example:
https://www.transifex.com/bitcoin/bitcoin/viewstrings/#ja/qt-translation-011x/47533089?q=sent
https://www.transifex.com/bitcoin/bitcoin/viewstrings/#ja/qt-translation-011x/47533089?q=received
Demo of changes:
Current UI:
With this pull request:
Happy to add a screenshot if it would help.