Order CTxMemPool::queryHashes result by feerate including descendents.#7629
Closed
pstratem wants to merge 1 commit intobitcoin:masterfrom
Closed
Order CTxMemPool::queryHashes result by feerate including descendents.#7629pstratem wants to merge 1 commit intobitcoin:masterfrom
pstratem wants to merge 1 commit intobitcoin:masterfrom
Conversation
pstratem
force-pushed
the
2016-03-01-queryhashes
branch
from
a7b04fc to
a6cf596
Compare
Member
|
Motivation? Curious whether whatever you're using this for should be using descendant fee rate or ancestor fee rate (see #7594)... |
pstratem
force-pushed
the
2016-03-01-queryhashes
branch
from
a6cf596 to
0a94cf6
Compare
Contributor
Author
|
@sdaftuar the motivation is two part first to ensure mempool walks are in an order which avoids any orphans second to make the feefilter command more efficient in combination with the mempool p2p command |
Contributor
Author
|
@sdaftuar is right this should be using ancestor indexing |
Member
|
@pstratem Can you elaborate? How does this guarantee the avoidance of orphans? Transaction descendants can have both higher or lower feerate than the parent. |
Contributor
Author
|
@sipa it doesn't i mis understood what was being indexed. i'll fix this properly later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.