qt: Make it possible to show details for multiple transactions

[laanwj]

A small GUI annoyance for me has always been that it's impossible to have multiple transaction detail windows open, for example to compare transactions.

This patch makes the window non-modal so that it is possible to open transaction details at will.

[jonasschnelli]

Nice! Also though about this. Thanks.

utACK 1f3b3fd48bb6c5787893529862430bd77b2c7fb3

[laanwj]

Another thing to consider here now may be to add some information to the window title. After all if there are multiple open it may be useful to distinguish them in taskbars etc.

I'm not sure on what to add though; transaction id seems to be of limited usefulness. Maybe date/recipient/amount.

[paveljanik]

Numbering the windows?

[laanwj]

Numbering doesn't seem more useful to me than just keeping them with the same window title. It needs to actually identify the transaction.
(also this opens up issues with reusing or not reusing numbers, I'd rather just add (part of) the transaction id in that case)

[jonasschnelli]

What about the shortened transaction id (middle truncated). Something like 4d8fad...8dd9f9 for 4d8fad408da55d4b54e3be97960db06d78489f5984e0a6e8ada082295e8dd9f9?

[paveljanik]

Full tx ID. window manager/... will shorten it if needed (ie. Transaction details: tx_id).

[jonasschnelli]

To make this work on OSX (not sure about Windows) you need to make the dialog non-modal.

diff --git a/src/qt/transactionview.cpp b/src/qt/transactionview.cpp
index eb6111e..bfdd7a4 100644
--- a/src/qt/transactionview.cpp
+++ b/src/qt/transactionview.cpp
@@ -480,6 +480,7 @@ void TransactionView::showDetails()
     {
         TransactionDescDialog *dlg = new TransactionDescDialog(selection.at(0));
         dlg->setAttribute(Qt::WA_DeleteOnClose);
+        dlg->setModal(false);
         dlg->show();
     }
 }

[jonasschnelli]

I tested with the full transaction-ID as window title. LGTM.

diff --git a/src/qt/transactiondescdialog.cpp b/src/qt/transactiondescdialog.cpp
index f7b6995..5c10d84 100644
--- a/src/qt/transactiondescdialog.cpp
+++ b/src/qt/transactiondescdialog.cpp
@@ -15,6 +15,7 @@ TransactionDescDialog::TransactionDescDialog(const QModelIndex &idx, QWidget *pa
 {
     ui->setupUi(this);
     QString desc = idx.data(TransactionTableModel::LongDescriptionRole).toString();
+    setWindowTitle(tr("Details for %1").arg(idx.data(TransactionTableModel::TxHashRole).toString()));
     ui->detailText->setHtml(desc);
 }

[laanwj]

@jonasschnelli: Interesting, do you know why is this necessary specifically here, how about the other places where we use setAttribute(Qt::WA_DeleteOnClose)?

• src/qt/receivecoinsdialog.cpp: on_receiveButton_clicked, on_recentRequestsView_doubleClicked
• src/qt/walletview.cpp: WalletView::gotoSignMessageTab, WalletView::gotoVerifyMessageTab

(excluding the splash window and the shutdown window as they are special cases anyway)

[laanwj]

From the QDialog documentation:
http://doc.qt.io/qt-5/qdialog.html#modal-prop "By default, this property is false"

It's only dlg->exec() which sets it to true, which we don't use anymore (here). I don't think we need to set it.

Edit: screenshot looks good, I do think we should prefix the title Transaction details: though so we don't get an all-hex title :)

[paveljanik]

Works OK here, even without setModal(false).

[jonasschnelli]

Right. setModal() is not required. Was a local issue here.

[jonasschnelli]

Using "Details for" instead of "Transaction Details" would not truncate the window title (at least on OSX).

Tested ACK 17a6a21.

[laanwj]

Yes, Abbreviating to "Details for %s" makes sense, will do that, it was just that having the whole title hex was a bit too cypherpunk even for me :)

[laanwj]

Added a new commit that puts the tx id in the window title (as well as removes the old "Transaction details" translation string).