Rename CTxinWitness -> CTxInWitness#8311
Merged
laanwj merged 1 commit intobitcoin:masterfrom Jul 14, 2016
AtakamaLLC:CTxInWitness
Merged
Rename CTxinWitness -> CTxInWitness#8311laanwj merged 1 commit intobitcoin:masterfrom AtakamaLLC:CTxInWitness
laanwj merged 1 commit intobitcoin:masterfrom
AtakamaLLC:CTxInWitness
Conversation
Contributor
|
Concept ACK I don't really care what color the bikesheds are painted, but can we please just use the same colour again? :) |
Contributor
|
utACK 36ae37a |
Author
|
Tested ACK Been running this since shortly before I made the PR. |
Contributor
|
utACK 36ae37a |
Member
|
Indeed, the precedent seems to be @sipa do you agree with this naming change? If we do this it should be merged before 0.13 to avoid having different spellings in different releases. |
Contributor
|
@laanwj ack 0.13.0 milestone - I'd like to have naming consistent in python-bitcoinlib too. |
laanwj
added a commit
that referenced
this pull request
Jul 14, 2016
36ae37a Rename CTxinWitness -> CTxInWitness (Bob McElrath)
Member
|
trivial-ACK 36ae37a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...in order to match the convention used elsewhere CTxIn (notice the capital 'I').
I'm mirroring these changes into python-bitcoinlib, which keeps all the same class names as Bitcoin Core. This incongruity in naming stuck out to me.