Fix #846. Allow negative options such as "nolisten=1" in bitcoin.conf as well as on the command line.#847
Merged
dooglus merged 0 commit intobitcoin:masterfrom Feb 16, 2012
Merged
Conversation
Contributor
|
I think a separate method called from ParseParameters and ReadConfigFile is the better way to go. |
ptschip
pushed a commit
to ptschip/bitcoin
that referenced
this pull request
Dec 19, 2017
* New bitmask based category logging system * removed a stray | in util_Logging * fix all comments from bitcoin#847 review
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Apr 6, 2019
dc168d1 fix to display missing clock5.png tx image (joeuhren) Tree-SHA512: d10828e76ad1b2e034b013a1c3cac9cf79dfdc642a11d1a6493d615a19982d50fc09343b3b39171ba7c25202f29ed0532f1bc539c42fbdad37a19e58adcc48b1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I copied this whole block out of ParseParameters() and changed the variable names.
Perhaps it's better to move this code into a new function and call it from both places.
Or we could just process all the "-no" parameters at once, after bitcoin.conf has been processed.
The "--" -> "-" processing needs to stay where it is, however, so that --datadir= can be used to locate bitcoin.conf.