Skip to content

[trivial] fix mempool comment (outdated by BIP125)#8796

Merged
laanwj merged 1 commit intobitcoin:masterfrom
jnewbery:trivial_comment
Sep 26, 2016
Merged

[trivial] fix mempool comment (outdated by BIP125)#8796
laanwj merged 1 commit intobitcoin:masterfrom
jnewbery:trivial_comment

Conversation

@jnewbery
Copy link
Copy Markdown
Contributor

[trivial] Comment in txmempool.h was outdated by BIP 125 and is now incorrect. This PR fixes that comment.

@sdaftuar
Copy link
Copy Markdown
Member

ACK

Copy link
Copy Markdown
Contributor

@jonasschnelli jonasschnelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Comment thread src/txmempool.h Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also transactions that don't make the minimum fee requirements.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've added that and squashed my commits.

@laanwj laanwj merged commit c14ffd5 into bitcoin:master Sep 26, 2016
laanwj added a commit that referenced this pull request Sep 26, 2016
c14ffd5 [trivial] fix mempool comment (outdated by BIP125) (jonnynewbs)
@jnewbery jnewbery deleted the trivial_comment branch September 26, 2016 13:48
codablock pushed a commit to codablock/dash that referenced this pull request Jan 11, 2018
c14ffd5 [trivial] fix mempool comment (outdated by BIP125) (jonnynewbs)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
c14ffd5 [trivial] fix mempool comment (outdated by BIP125) (jonnynewbs)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants