[depends] Fix Qt compilation with Xcode 8#8820
Merged
laanwj merged 1 commit intobitcoin:masterfrom Sep 28, 2016
Merged
Conversation
Contributor
|
Looks good. I have never used the depends build system on OSX, but I'll give it try soon. |
laanwj
added a commit
that referenced
this pull request
Sep 28, 2016
5776e8a [depends] Fix Qt compilation with Xcode 8 (fanquake)
Member
|
Qt 5.6.2 has been released yesterday. So we could get rid of the patch by bumping from 5.6.1 to 5.6.2, if that makes sense. |
Member
|
On master I'd rather make a major version bump, I remember there were some other reasons to go to 5.7. |
Member
|
Oh, 0.13 is on 5.6.1 as well. Not sure what to do then. Qt 5.7 is tracked over there: #8237 |
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 12, 2018
5776e8a [depends] Fix Qt compilation with Xcode 8 (fanquake)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling Qt with the depends system is currently broken on OSX with Xcode 8 upstream Qt bug (Xcode 8 is no longer in beta).
This patches qtbase/configure and qtbse/mkspecs/features/mac/default_pre.prf to work around the issue.
Up for discussion wether we patch this now, wait for a 5.6.2 release and move depends to it, or leave this broken until we move to 5.7 / 5.8 in future.