Closed
Conversation
Contributor
|
Let's slow down please and let the review part to catch you... thx |
Member
|
Where is this deprecated? I prefer the current form... :/ |
Member
|
I don't like C++ style casts for simple integer types. Sure, C-style casts can be dangerous in general, but for simple types there is no such risk, and result in much less cluttered notation. I do prefer |
practicalswift
force-pushed
the
avoid-functional-cast-expression
branch
from
0eb2e5c to
5da3f42
Compare
practicalswift
changed the title
Contributor
Author
|
@sipa PR updated accordingly. Looks OK? :-) |
Member
|
Our style guide does not mention what is preferred and it does not seem relevant, so tend to NACK. |
Contributor
Author
|
Closing since consensus seems to be that this change is unnecessary :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.