Silence "warning: "MSG_DONTWAIT" redefined" when compiling under Linux #10246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
practicalswift
force-pushed
the
silence-msg_dontwait-warning
branch
from
715b51c to
b8b1e80
Compare
Handle the case where !defined(HAVE_MSG_DONTWAIT) does not imply !defined(MSG_DONTWAIT).
Prior to this commit:
```
$ make
…
CXX libbitcoin_server_a-net.o
net.cpp:55:0: warning: "MSG_DONTWAIT" redefined
#define MSG_DONTWAIT 0
^
In file included from /usr/include/x86_64-linux-gnu/sys/socket.h:38:0,
from compat.h:38,
from netaddress.h:12,
from addrman.h:9,
from net.h:10,
from net.cpp:10:
/usr/include/x86_64-linux-gnu/bits/socket.h:195:0: note: this is the location of the previous definition
#define MSG_DONTWAIT MSG_DONTWAIT
^
…
```
After this commit:
```
$ make
…
CXX libbitcoin_server_a-net.o
…
```
practicalswift
force-pushed
the
silence-msg_dontwait-warning
branch
from
b8b1e80 to
1eeee49
Compare
|
This is not the correct fix. When it's defined, configure should also define HAVE_MSG_DONTWAIT |
|
Yet another case of this :(. See #10228 for the fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the case where
!defined(HAVE_MSG_DONTWAIT)does not imply!defined(MSG_DONTWAIT).Prior to this commit:
After this commit: