freebsd 11.1 g++7 build #11542
Closed
freebsd 11.1 g++7 build #11542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
reviewed
Oct 21, 2017
| uint32_t nSequenceIn=std::numeric_limits<unsigned int>::max(); | ||
| if (vStrInputParts.size() > 2) | ||
| nSequenceIn = std::stoul(vStrInputParts[2]); | ||
| nSequenceIn = stoul(vStrInputParts[2], 0, 10); |
There was a problem hiding this comment.
Please keep using the fully-qualified name
|
Did anything change in the C++ standard to require explicitly passing these arguments instead of implicitly by default? |
paveljanik
reviewed
Oct 21, 2017
| #include "utilstrencodings.h" | ||
|
|
||
| #include <stdio.h> | ||
|
|
There was a problem hiding this comment.
I think that this is the only valid change right now.
...
But as we use fprintf to stderr for printing error messages...
|
Please wait, I'll gmake clean && gmake without the patch :) |
|
Please disregard my patch! I have now compiled&installed&runned bitcoind with both Clang and g++7. |
|
Thanks @lyrra, I'll close this PR then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build for freebsd 11.1 g++7 (really moving to g++ std11)