Skip to content

[rpc] nit: fix typo for entry description string #13109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2018
Merged

[rpc] nit: fix typo for entry description string #13109

merged 1 commit into from
Apr 30, 2018

Conversation

@mryandao
Copy link
Contributor

@mryandao mryandao commented Apr 28, 2018 •
edited
Loading

@mryandao mryandao mentioned this pull request Apr 28, 2018
Merged
promag
promag reviewed Apr 28, 2018
View reviewed changes
Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

fanquake
fanquake approved these changes Apr 28, 2018
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 18dee67

maflcko
maflcko reviewed Apr 28, 2018
View reviewed changes
src/rpc/blockchain.cpp Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetModFeesWithDescendants has nothing to do with the number of transactions, it returns a fee.

@mryandao mryandao force-pushed the fix-getrawmempool-fee-representation branch 2 times, most recently from 7ddb960 to 2773bac Compare April 30, 2018 01:39
@mryandao mryandao force-pushed the fix-getrawmempool-fee-representation branch from 2773bac to f7c414d Compare April 30, 2018 01:41
@jonasschnelli
Copy link
Contributor

utACK f7c414d

@fanquake
Copy link
Member

re-ACK f7c414d

@laanwj
Copy link
Member

laanwj commented Apr 30, 2018

utACK, the field is indeed called "descendant" not "descendent"
f7c414d

@laanwj laanwj merged commit f7c414d into bitcoin:master Apr 30, 2018
laanwj added a commit that referenced this pull request Apr 30, 2018
@laanwj
Merge #13109: [rpc] nit: fix typo for entry description string
2199705 
f7c414d nit: fix typo for entry description string (mryandao)

Pull request description:

  #12240

Tree-SHA512: 2940c383069912b04d6fdbc1f0834970cae8ed725beb606916ee27501d8f6e1b3938647babb26137440166de3a9ac745048e306696d13817775eb406adb31f4a
@Bushstar Bushstar mentioned this pull request Apr 30, 2018
Merged
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 11, 2019
@laanwj
Merge #12240: [rpc] Introduced a new fees structure that aggregates…
a685181 
… all sub-field fee types denominated in BCH

Summary:
7de1de7 Add new fee structure with all sub-fields denominated in BTC (mryandao)

Pull request description:

  the denomination for `fee` is current in btc while the other such as `decendentFee` and `ancestorFee` are in satoshis.

Tree-SHA512: e428f6dca1d339f89ab73e38ce5903f5465c46b159069d9bcc3f8b1140fe6657fa49a11abe0088e9f7ba9999f64af72a349a4735bf5eaa61b8e4a185b23543f3

Backport of Core PR12240
bitcoin/bitcoin#12240

Also included PR13109 and PR13124 (small typo fixes)
bitcoin/bitcoin#13109
bitcoin/bitcoin#13124

Test Plan:
  make check
  test_runner.py

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4151
jonspock pushed a commit to jonspock/devault that referenced this pull request Dec 27, 2019
@laanwj @jonspock
Merge #12240: [rpc] Introduced a new fees structure that aggregates…
703ea34 
… all sub-field fee types denominated in BCH

Summary:
7de1de7 Add new fee structure with all sub-fields denominated in BTC (mryandao)

Pull request description:

  the denomination for `fee` is current in btc while the other such as `decendentFee` and `ancestorFee` are in satoshis.

Tree-SHA512: e428f6dca1d339f89ab73e38ce5903f5465c46b159069d9bcc3f8b1140fe6657fa49a11abe0088e9f7ba9999f64af72a349a4735bf5eaa61b8e4a185b23543f3

Backport of Core PR12240
bitcoin/bitcoin#12240

Also included PR13109 and PR13124 (small typo fixes)
bitcoin/bitcoin#13109
bitcoin/bitcoin#13124

Test Plan:
  make check
  test_runner.py

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4151
jonspock pushed a commit to devaultcrypto/devault that referenced this pull request Dec 29, 2019
@laanwj @jonspock
Merge #12240: [rpc] Introduced a new fees structure that aggregates…
27aa16c 
… all sub-field fee types denominated in BCH

Summary:
7de1de7 Add new fee structure with all sub-fields denominated in BTC (mryandao)

Pull request description:

  the denomination for `fee` is current in btc while the other such as `decendentFee` and `ancestorFee` are in satoshis.

Tree-SHA512: e428f6dca1d339f89ab73e38ce5903f5465c46b159069d9bcc3f8b1140fe6657fa49a11abe0088e9f7ba9999f64af72a349a4735bf5eaa61b8e4a185b23543f3

Backport of Core PR12240
bitcoin/bitcoin#12240

Also included PR13109 and PR13124 (small typo fixes)
bitcoin/bitcoin#13109
bitcoin/bitcoin#13124

Test Plan:
  make check
  test_runner.py

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4151
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request May 21, 2021
@laanwj @UdjinM6
Merge bitcoin#13109: [rpc] nit: fix typo for entry description string
616549f 
f7c414d nit: fix typo for entry description string (mryandao)

Pull request description:

  bitcoin#12240

Tree-SHA512: 2940c383069912b04d6fdbc1f0834970cae8ed725beb606916ee27501d8f6e1b3938647babb26137440166de3a9ac745048e306696d13817775eb406adb31f4a
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request May 25, 2021
@laanwj @UdjinM6
Merge bitcoin#13109: [rpc] nit: fix typo for entry description string
9a6855a 
f7c414d nit: fix typo for entry description string (mryandao)

Pull request description:

  bitcoin#12240

Tree-SHA512: 2940c383069912b04d6fdbc1f0834970cae8ed725beb606916ee27501d8f6e1b3938647babb26137440166de3a9ac745048e306696d13817775eb406adb31f4a
TheArbitrator pushed a commit to TheArbitrator/dash that referenced this pull request Jun 4, 2021
@laanwj @erhari08
Merge bitcoin#13109: [rpc] nit: fix typo for entry description string
957457f 
f7c414d nit: fix typo for entry description string (mryandao)

Pull request description:

  bitcoin#12240

Tree-SHA512: 2940c383069912b04d6fdbc1f0834970cae8ed725beb606916ee27501d8f6e1b3938647babb26137440166de3a9ac745048e306696d13817775eb406adb31f4a
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fanquake fanquake fanquake approved these changes

+2 more reviewers

@promag promag promag left review comments

@maflcko maflcko maflcko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs RPC/REST/ZMQ

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mryandao @jonasschnelli @fanquake @laanwj @promag @maflcko