[WIP] Refactoring platform-specific code in util.h/util.cpp #13196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glaksmono Thanks for wanting to work on #12697. For future reference, ideally [WIP] PRs should only be opened when some code has been written, and you need help/feedback in regards to code or design decisions. We don't really use them for "claiming" issues to work on, a comment in the relevant issue is enough for that. (they will also consume Travis resources unnecessarily). |
|
Got it @fanquake apologise. Will keep that in mind for the future. |
9a75d29 change the error result from `PIE` to `DYNAMIC_BASE`. And there are no test for 64-bit, so I made one
… configuration files
…from the core jobs
self.nodes[0] creates an address which is watch-only-shared with self.nodes[3]. If nodes[0] spends the associated UTXO during any of its sends later, the watchonly test will fail, as nodes[3] now has insufficient funds. Note that this also adds a new find_vout_for_address function to the test framework.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take all of the functions that are specific to Windows or Unix, and create a common set of methods in a new header file, all combined in the
src/util/folder.The goal of this PR is to break
src/util.cppandsrc/util.hinto the following files:For Windows:
src/util/platform_windows.hsrc/util/platform_windows.cppFor Mac & Linux:
src/util/platform_posix.hsrc/util/platform_posix.cppIssue Reference: #12697