Skip to content

Conversation

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Jul 29, 2018

  • Add missing [[noreturn]] to handleRunawayException(…)
  • Enable -Wsuggest-attribute=noreturn if available

@fanquake
Copy link
Member

macOS travis:

  CXXLD    test/test_bitcoin_fuzzy
  CXXLD    bitcoind
qt/bitcoin.cpp:527:3: error: function declared '[[noreturn]]' after its first declaration
[[noreturn]] void BitcoinApplication::handleRunawayException(const QString &message)
  ^
qt/bitcoin.cpp:215:10: note: declaration missing '[[noreturn]]' attribute is here
    void handleRunawayException(const QString &message);
         ^
1 error generated.
Makefile:8653: recipe for target 'qt/qt_bitcoin_qt-bitcoin.o' failed

@practicalswift practicalswift force-pushed the handleRunawayException branch from 6ae8f47 to fd24f9c Compare July 30, 2018 10:48
@practicalswift practicalswift force-pushed the handleRunawayException branch from fd24f9c to c9f067e Compare July 30, 2018 11:50
@DrahtBot
Copy link
Contributor

Note to reviewers: This pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@practicalswift practicalswift deleted the handleRunawayException branch April 10, 2021 19:35
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants