Skip to content

Use linker-arguments only when linking #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2012
Merged

Use linker-arguments only when linking #1514

merged 1 commit into from
Jul 17, 2012

Conversation

@muggenhor
Copy link
Contributor

Passing linker-arguments when only compiling will cause warnings with Clang. This change fixes those.

Specifically this addresses warnings like these:

clang: warning: -Wl,-z,relro: 'linker' input unused when '-c' is present
clang: warning: -Wl,-z,now: 'linker' input unused when '-c' is present
clang: warning: argument unused during compilation: '-pie'

@jgarzik
Copy link
Contributor

jgarzik commented Jun 24, 2012

why not use LDFLAGS?

@muggenhor
Copy link
Contributor Author

The reason was to prevent overriding LDFLAGS given on the command-line, but I've addressed this by using the same trick as for CXXFLAGS.

sipa
sipa reviewed Jun 24, 2012
View reviewed changes
src/makefile.unix Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$(LDHARDENING) is already included in $(xLDFLAGS), it seems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that was a bad left-over. Removed it and re-pushed.

@gavinandresen
Copy link
Contributor

ACK

@TheBlueMatt
Copy link
Contributor

Can you rebase and remove the merge commit? Also, ACK and can we get this merged so it doesn't sit around forever?
Also, clang's lto is petty awesome with Bitcoin, I got these earlier today with bitcoin-qt:
clang-lto: " block index 6523ms" gcc-lto: " block index 8497ms"
For that reason, I'd kinda like to look into building releases with clang, but we need this.

@TheBlueMatt TheBlueMatt mentioned this pull request Jul 4, 2012
Closed
@laanwj
Copy link
Member

laanwj commented Jul 8, 2012

ACK

@muggenhor
Use linker-arguments only when linking
f04f245 
Passing linker-arguments when only compiling will cause warnings with
Clang. This change fixes those.

Signed-off-by: Giel van Schijndel <me@mortis.eu>
@muggenhor
Copy link
Contributor Author

Rebased (again), and (still) ready for merge.

@gavinandresen gavinandresen merged commit f04f245 into bitcoin:master Jul 17, 2012
suprnurd pushed a commit to chaincoin-legacy/chaincoin that referenced this pull request Dec 5, 2017
@UdjinM6
Implement BIP69 outside of CTxIn/CTxOut (bitcoin#1514)
397ea95 
Apply BIP69 on transaction creation only, fix inputs order to match the BIP
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@muggenhor @jgarzik @gavinandresen @TheBlueMatt @laanwj @sipa