[refactor] CNode: Use C++11 default member initializers #15144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Concept ACK. Will review. |
Empact
reviewed
Jan 10, 2019
| std::atomic<int64_t> nPingUsecTime{0}; | ||
| // Best measured round-trip time. | ||
| std::atomic<int64_t> nMinPingUsecTime; | ||
| std::atomic<int64_t> nMinPingUsecTime{std::numeric_limits<int64_t>::max()}; |
|
ACK fac2f5e:
|
|
utACK fac2f5e |
| nTimeOffset = 0; | ||
| addrName = addrNameIn == "" ? addr.ToStringIPPort() : addrNameIn; | ||
| nVersion = 0; | ||
| strSubVer = ""; |
There was a problem hiding this comment.
Remove this redundant line? :-)
|
utACK fac2f5e |
|
utACK fac2f5e |
laanwj
added a commit
that referenced
this pull request
Jan 14, 2019
fac2f5e Use C++11 default member initializers (MarcoFalke) Pull request description: The second and last change on this topic (c.f. #15109). Split up because the diff would otherwise interleave, making review harder than necessary. This is not a stylistic change, but a change that avoids bugs such as: * fix uninitialized read when stringifying an addrLocal #14728 * qt: Initialize members in WalletModel #12426 * net: correctly initialize nMinPingUsecTime #6636 * ... Tree-SHA512: 547ae72b87aeaed5890eb5fdcff612bfc93354632b238d89e1e1c0487187f39609bcdc537ef21345e0aea8cfcf1ea48da432d672c5386dd87cf58742446a86b1
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Aug 22, 2021
Backporting Merge bitcoin#15144: [refactor] CNode: Use C++11 default member initializers Resolved Merge conflicts after cherry-picking the backport commit hash
vijaydasmp
added a commit
to vijaydasmp/dash
that referenced
this pull request
Aug 22, 2021
…1 default member initializers
vijaydasmp
added a commit
to vijaydasmp/dash
that referenced
this pull request
Aug 22, 2021
…Use C++11 default member initializers" This reverts commit b8a07d9.
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Aug 29, 2021
vijaydasmp
added a commit
to vijaydasmp/dash
that referenced
this pull request
Aug 29, 2021
…ber initializers
vijaydasmp
added a commit
to vijaydasmp/dash
that referenced
this pull request
Aug 30, 2021
PastaPastaPasta
pushed a commit
to dashpay/dash
that referenced
this pull request
Aug 31, 2021
…alizers (#4371) * Merge bitcoin#15144: [refactor] CNode: Use C++11 default member initializers * Backport Merge bitcoin#15144: [refactor] CNode: Use C++11 default member initializers * Merge bitcoin#15144: [refactor] CNode: Use C++11 default member initializers #4371 Co-authored-by: Wladimir J. van der Laan <laanwj@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second and last change on this topic (c.f. #15109). Split up because the diff would otherwise interleave, making review harder than necessary.
This is not a stylistic change, but a change that avoids bugs such as: