appveyor: ignore functional test failure #15376
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't seem that bad lately. We also have intermittent failures on travis, so I am not sure if this will improve things significantly. |
|
@MarcoFalke said
Personally I go and see what failed so I'm fine with having it red. I may be wrong but with this change we might end up not taking care of appveyor failures. |
|
Ok. Let's close it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggested by MarcoFalke in #14446 (comment)
Unfortunately that
echodoesn't changeerrorlevelon Windows. So I add a dummy command to set the return code to be 0 at the end.Tested in here: https://ci.appveyor.com/project/ken2812221/bitcoin/builds/22245530