GUI: optionsmodel cleanup #1572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK |
- cleanup optionsmodel before adding new proxy options
- place SOCKS version stuff below proxy port (IP, Port, SOCKS version)
- simplyfy some parts of the code (e.g. don't check IP and port, as this
is done in optionsdialog anyway, remove unneeded {} in switch/case)
- small cosmetic changes in the header for better readability
|
Rebased without further code changes, because I based #1589 on this! |
nifgraup
pushed a commit
to nifgraup/auroracoin-project
that referenced
this pull request
Mar 30, 2014
GUI: optionsmodel cleanup
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
…1572) * Remove un-needed #includes (what is the policy?) Data was duplicated in masternode_info_t and CMasternode classes: * CMasternode is changed to inherit from masternode_info_t so the data members are inherited rather than repeated (also inherits unrepeated nTimeLastPing and fInfoValid members; this slight intrusiveness made up for in simplicity). * Use in-class member initializers (C++11) for defaults, so only non-default initializers are required in the lists. Allows to shorten repetitous constructor initializer lists. This makes checking for uninitialized data simpler. * Default constructors are defined as "= default;" if possible. * masternode_info_t is changed to behave like an aggregate (but requires over-complicated constructors until c++14). There are pros and cons here - aggregate initialization is convenient but implicit). * Removed user-defined swap functions. They appear to only be used in operator= definitions, using the copy-in,swap-and-return idiom: * Default operator=, where possible. * Move in class `friend bool operator==` out-of-class.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is done in optionsdialog anyway, remove unneeded {} in switch/case)
This is what I intend to do with the proxy options (not included here):
