0.17.2 backport: build with -fstack-reuse=none and test case #16163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github-Pull: bitcoin#15983 Rebased-From: faf38bc
Github-Pull: bitcoin#15985 Rebased-From: 58e291c
maflcko
changed the title
|
ACK b5a4abe by review of the linked PRs, the GCC bug and option, and visual inspection/comparison of the ported code |
|
Code review + relevancy for backport ACK b5a4abe |
laanwj
added a commit
that referenced
this pull request
Jun 13, 2019
… case b5a4abe Add test for GCC bug 90348 (Pieter Wuille) 05fb9f7 build with -fstack-reuse=none (MarcoFalke) Pull request description: Backports: * [build with -fstack-reuse=none](#15983) * [Add test for GCC bug 90348](#15985) b5a4abe has been modified to replace the `setup_common.h` with `test_bitcoin.h` include. ACKs for commit b5a4ab: Empact: ACK b5a4abe by review of the linked PRs, the GCC bug and option, and visual inspection/comparison of the ported code laanwj: Code review + relevancy for backport ACK b5a4abe Tree-SHA512: cdfdc6e2f208e8dc6a8a86cd7a7ed0f2a6f96604a0663efc970f580f693c1975353341fa8434b23de3cb681e03c6918e3342178752ed595d16a0ec50db913266
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports:
b5a4abe has been modified to replace the
setup_common.hwithtest_bitcoin.hinclude.