script: Remove trailing whitespace on blank lines. #17003
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran `autopep8 --in-place --select=W293 --recursive .` to find this.
jbampton
changed the title
|
I could be wrong, but my understanding has been that changes like this are maybe ok when they are done alongside more important changes involving the file. doc/developer-notes.md: "Do not submit patches solely to modify the style of existing code." CONTRIBUTING.md: "Trivial pull requests or pull requests that refactor the code with no clear benefits may be immediately closed by the maintainers to reduce unnecessary workload on reviewing." YMMV. |
|
Don't care that much ACK, https://github.com/bitcoin/bitcoin/pull/17003/files?w=1. |
|
Thanks for wanting to contribute, but PRs need to fix actual problems (preferably, issues that have been filed). We do not accept PRs like this that just manipulate whitespace. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran
autopep8 --in-place --select=W293 --recursive .to find this.