Keyboard shortcut duplicate in sign/verify message window.

[burger2]

in the "Signatures - Sign / Verify a Message" Window we have the keyboard shortcut alt+S and alt+V to switch tabs and the same shortcuts to Sign or Verify the message (These two buttons should be changed to alt+m and the shortcuts for the tabs should the same).

Tested with English and Swedish translations and client version 0.7.0 on 64-bit windows 7 and 0.7.1rc (compiled latest sources from github) on 64-bit ubuntu 12.4.

[burger2]

The bug is still in 0.7.1 swedish translation on windows 8 64-bit.

[luke-jr]

@burger2 Can you check https://www.transifex.com/projects/p/bitcoin/ and correct it if still a problem there?

[Diapolo]

@burger2 is right, the tab and the button to execute the sign / verify have the same shortcuts. I think it's a great mess to need to re-translate such strings for all used languages when we need to change them because of a dup shortcut :-/.

[burger2]

I was gonna try compiling the latest sources from git and with the latest translations from transifex in my ubuntu install but after my ubuntu got upgraded to 12.10 I got the new database engine that gives me errors when compiling so I haven't done any testing =(

I'll check transifex soon...

[luke-jr]

@Diapolo We don't, I can easily copy the old translations - and fixes like this to the English strings shouldn't affect others, though of course in this case the translation happens to have the same bug :)

[burger2]

Now I got it compiled finally in ubuntu and I still got the same bug. I think I have an easy fix for it.

Just change the shortcut key to M (Verify &Message) & (Sign &Message) of the button and leave the tabs shortcuts as they are. I tried this in QT creator design mode and just changed it and recompiled and it worked for me.

[burger2]

Now I just need to learn how to use git to submit this =)

diff --git a/src/qt/forms/signverifymessagedialog.ui b/src/qt/forms/signverifymessagedialog.ui
index 8128bdf..4887110 100644
--- a/src/qt/forms/signverifymessagedialog.ui
+++ b/src/qt/forms/signverifymessagedialog.ui
@@ -148,7 +148,7 @@
             <string>Sign the message to prove you own this Bitcoin address</string>
            </property>
            <property name="text">
-            <string>&amp;Sign Message</string>
+            <string>Sign &amp;Message</string>
            </property>
            <property name="icon">
             <iconset resource="../bitcoin.qrc">
@@ -294,7 +294,7 @@
             <string>Verify the message to ensure it was signed with the specified Bitcoin address</string>
            </property>
            <property name="text">
-            <string>&amp;Verify Message</string>
+            <string>Verify &amp;Message</string>
            </property>
            <property name="icon">
             <iconset resource="../bitcoin.qrc">

[luke-jr]

I'm confused. Are we talking about English or Swedish? :/

[burger2]

The bug is in both... the diff is for the English string so that translators notice the bug.

[burger2]

Gah... I'm not compatible with git... just doing all wrong again =(

[burger2]

I forgot to close this... it's was fixed a long time ago =)