test: Use proper mocktime for uptime #21164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 12, 2021 18:13
…action Stop initializing nStartupTime to system time. This is needed for many things: * It is making it harder to assert that fuzzing only uses mocked time. * When using mocked time in the program arguments, nStartupTime will be incorrectly initialized to system time.
|
Concept ACK, first skim of code looks pretty good. |
|
Whoops, I think we crossed wires and I created #21165 - happy to close it if you prefer. I was able to accomplish the faster test without any C++ changes so might be easier to review. |
|
Ah, thanks. Closing this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/bitcoin/bitcoin/pull/19884/files#r575336503