Skip to content

Conversation

@fanquake
Copy link
Member

While not many of these are used, some, like HAVE_DLLEXPORT_ATTRIBUTE, are used when creating libbitcoinconsensus.

Given this file is static, also just remove everything that is commented out.

@sipsorcery
Copy link
Contributor

tACK.

Builds fine for me on Windows 10.

I was also unable to find any reference to the defines below in the source code when doing a Windows build. I was able to build with them removed.

LT_OBJDIR
PACKAGE_STRING
PACKAGE_TARNAME

#if defined AC_APPLE_UNIVERSAL_BUILD
# if defined __BIG_ENDIAN__
#  define WORDS_BIGENDIAN 1
# endif
#else
# ifndef WORDS_BIGENDIAN
/* #  undef WORDS_BIGENDIAN */
# endif
#endif

_FILE_OFFSET_BITS
STDC_HEADERS

While not many of these are used, some, like HAVE_DLLEXPORT_ATTRIBUTE, are used
when creating libbitcoinconsensus.

Given this file is static, also just remove everything that is commented out.
@fanquake fanquake force-pushed the update_msvc_bitcoin_configg branch from 4fd7aec to ae4ad1a Compare September 2, 2021 03:14
@fanquake
Copy link
Member Author

fanquake commented Sep 2, 2021

@sipsorcery thanks. Added some more removals.

@sipsorcery
Copy link
Contributor

tACK ae4ad1a.

@fanquake fanquake merged commit d6034e4 into bitcoin:master Sep 2, 2021
@fanquake fanquake deleted the update_msvc_bitcoin_configg branch September 2, 2021 07:44
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Sep 2, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants