doc: Fix CWalletTx::Confirmation doc #23332
Conversation
maflcko
force-pushed
the
2110-docWalletConfirm
branch
from
fa4e8fe to
faf9a9f
Compare
maflcko
force-pushed
the
2110-docWalletConfirm
branch
from
faf9a9f to
fa8fef6
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Code review ACK fa8fef6 |
|
cc Ryan @ryanofsky |
| /* Used by TransactionAddedToMemorypool/BlockConnected/Disconnected/ScanForWalletTransactions. | ||
| * Should be called with non-zero block_hash and posInBlock if this is for a transaction that is included in a block. */ |
There was a problem hiding this comment.
In commit "doc: Fix CWalletTx::Confirmation doc" (fa8fef6)
Minor: This comment does seem useful to me and I'd probably s/non-zero block_hash and posInBlock/confirmation/ instead of dropping it.
There was a problem hiding this comment.
This is already explained in the Confirmation doc:
/** Confirmation includes tx status and a triplet of {block height/block hash/tx index in block} ...
There was a problem hiding this comment.
If you think this is important to explain, it might be better to put the comment to TxStateConfirmed from #21206?
fa8fef6 doc: Fix CWalletTx::Confirmation doc (MarcoFalke) Pull request description: Follow-up to: * commit 700c42b, which replaced pIndex with block_hash in AddToWalletIfInvolvingMe. * commit 9700fcb, which replaced posInBlock with confirm.nIndex. ACKs for top commit: laanwj: Code review ACK fa8fef6 ryanofsky: Code review ACK fa8fef6 Tree-SHA512: e7643b8e9200b8ebab3eda30435ad77006568a03476006013c9ac42c826c84e42e29bcdefc6f443fe4d55e76e903bfed5aa7a51f831665001c204634b6f06508
4 participants
Follow-up to:
commit 700c42b, which replaced pIndex
with block_hash in AddToWalletIfInvolvingMe.
commit 9700fcb, which replaced
posInBlock with confirm.nIndex.