Skip to content

doc: update release-process.md #24594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2022
Merged

doc: update release-process.md #24594

merged 1 commit into from
Apr 2, 2022
+24 −25

Conversation

@gruve-p
Copy link
Contributor

@gruve-p gruve-p commented Mar 16, 2022

No description provided.

@fanquake fanquake added the Docs label Mar 16, 2022
jonatack
jonatack reviewed Mar 16, 2022
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem correct from referencing contrib/guix/README.md but I don't have deep context here.

ACK ba7d150

hebasto
hebasto reviewed Mar 17, 2022
View reviewed changes
@gruve-p gruve-p requested review from hebasto and jonatack March 20, 2022 12:16
hebasto
hebasto reviewed Mar 20, 2022
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach ACK 0f12f9d.

@gruve-p gruve-p changed the title doc: update release-process.md with correct codesigning url doc: update release-process.md Mar 20, 2022
@gruve-p gruve-p marked this pull request as draft March 20, 2022 18:19
@gruve-p gruve-p marked this pull request as ready for review March 20, 2022 18:23
@gruve-p gruve-p requested a review from hebasto March 20, 2022 18:24
@gruve-p
Copy link
Contributor Author

gruve-p commented Mar 20, 2022

Also requesting review from @fanquake and @achow101 as codesigners. I think I went over my head with this PR (from changing 1 small URL to overhauling the whole doc). Happy to revert things if needed.

fanquake
fanquake reviewed Mar 21, 2022
View reviewed changes
@gruve-p gruve-p force-pushed the patch-1 branch 2 times, most recently from 5a86132 to 17b1320 Compare March 21, 2022 16:45
@gruve-p gruve-p requested a review from fanquake March 21, 2022 16:46
fanquake
fanquake reviewed Mar 25, 2022
View reviewed changes
@fanquake
Copy link
Member

Looks fine now (except for the last comment that needs). @achow101 want to sanity-check as well?

@gruve-p gruve-p requested a review from fanquake March 25, 2022 15:40
@achow101
Copy link
Member

achow101 commented Apr 1, 2022

ACK ac45a43

@fanquake fanquake merged commit 03251b6 into bitcoin:master Apr 2, 2022
@gruve-p gruve-p deleted the patch-1 branch April 2, 2022 09:35
Pragmatic2021
Pragmatic2021 reviewed Apr 2, 2022
View reviewed changes
Copy link

@Pragmatic2021 Pragmatic2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add or change. Does this go to the Bitcoin Core Wallet ?

@bitcoin bitcoin deleted a comment from Pragmatic2021 Apr 2, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 3, 2022
@fanquake
Merge bitcoin#24594: doc: update release-process.md
792984d
@gruve-p gruve-p mentioned this pull request May 31, 2022
Closed
7 tasks
@bitcoin bitcoin locked and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonatack jonatack Awaiting requested review from jonatack

@hebasto hebasto Awaiting requested review from hebasto

@fanquake fanquake Awaiting requested review from fanquake

2 more reviewers

@Pragmatic2021 Pragmatic2021 Pragmatic2021 left review comments

@its0x08 its0x08 its0x08 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gruve-p @fanquake @achow101 @jonatack @its0x08 @hebasto @Pragmatic2021