wallet: remove extra wtx lookup in AddToSpends #25427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
reviewed
Jun 20, 2022
Riahiamirreza
approved these changes
Jun 20, 2022
This method is only called from AddToWallet and LoadToWallet, places where we already have the wtx.
furszy
force-pushed
the
2022_wallet_AddToSpends_extra_wtx_lookup
branch
from
89e5822 to
32e5edc
Compare
|
Code review ACK 32e5edc |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jun 21, 2022
w0xlt
approved these changes
Jun 21, 2022
brunoerg
approved these changes
Jun 21, 2022
|
ACK 32e5edc |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
AddToSpendsis only called fromAddToWalletandLoadToWallet, places where we insert the wtx into the wallet map, we can directly feedAddToSpendswith thewtxand remove another extra lookup.