Skip to content

Conversation

@S3RK
Copy link
Contributor

@S3RK S3RK commented Jun 30, 2022

Change fee is payed by the recipient, so we don't need to add it to our target for coin selection.

@achow101
Copy link
Member

ACK 140d942

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #24584 (wallet: avoid mixing different OutputTypes during coin selection by josibake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@ishaanam
Copy link
Contributor

ishaanam commented Jul 1, 2022

ACK 140d942

Copy link
Member

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK 140d942

@achow101 achow101 merged commit aeab1b4 into bitcoin:master Jul 6, 2022
@bitcoin bitcoin locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants