doc: minor updates to guix README #25833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK 57a1a2d Checked the updated links. Both work as expected. |
adam2k
approved these changes
Aug 12, 2022
fanquake
reviewed
Aug 13, 2022
|
concept ack |
|
@satsie you will have to squash the commits as a clean commit history is required 👮 |
satsie
force-pushed
the
update-guix-readme
branch
from
6016114 to
9be134b
Compare
|
thanks @jarolrod! Rebased (and reread that section in the CONTRIBUTING.md) ^-^ update #1: I left in the "co-authored" part of the git commit message. It felt like the right thing to do, but can remove if that is against best practices update #2: linter got me on that 2 line commit message. will fix now! |
satsie
force-pushed
the
update-guix-readme
branch
from
9be134b to
98383d6
Compare
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 16, 2022
98383d6 doc: minor updates to guix README (Stacie) Pull request description: Two minor updates to the guix docs: - `contrib/guix/README.md`: fix broken link - `contrib/guix/INSTALL.md`: Change Ubuntu version in the section on distribution maintained packages from 21.04 (Hirsute Hippo) to 22.04 (Jammy Jellyfish). The previous link to the Ubuntu Guix package (https://packages.ubuntu.com/hirsute/guix) was for Hirsute. That link is now broken, likely because Hirsute reached EOL in January. I was unable to locate a general page for Ubuntu Guix packages so I replaced the broken link with the search results for all Ubuntu Guix packages. That page currently displays Guix packages for three different versions of Ubuntu. Happy to replace this link if there is a better option. ACKs for top commit: jarolrod: ACK 98383d6 Tree-SHA512: 6980f5952862773e79ca317edb4aadf6ff7c71726a0e4cb873c08bf51360c64e0498aabf4f53780f13cb06838eda93c89ba10fe35c4c8ae2b23191ab961b98f8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor updates to the guix docs:
contrib/guix/README.md: fix broken linkcontrib/guix/INSTALL.md: Change Ubuntu version in the section on distribution maintained packages from 21.04 (Hirsute Hippo) to 22.04 (Jammy Jellyfish). The previous link to the Ubuntu Guix package (https://packages.ubuntu.com/hirsute/guix) was for Hirsute. That link is now broken, likely because Hirsute reached EOL in January. I was unable to locate a general page for Ubuntu Guix packages so I replaced the broken link with the search results for all Ubuntu Guix packages. That page currently displays Guix packages for three different versions of Ubuntu. Happy to replace this link if there is a better option.