test: use sendall when emptying wallet
#25955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kouloumos
reviewed
Aug 30, 2022
Make sense, let me check other cases and if so, I will update them and change the PR title/desc. |
brunoerg
force-pushed
the
2022-08-sendall-wallet-groups
branch
from
53efdb1 to
923d245
Compare
brunoerg
changed the title
sendall in wallet_groups
brunoerg
changed the title
sendall when emptying wallet
|
Thanks for the suggestion, @kouloumos. Force-pushed replacing |
recipients receive equal share of the unspecified amount
ishaanam
reviewed
Aug 30, 2022
test/functional/wallet_basic.py
Outdated
| # Get all non-zero utxos together | ||
| chain_addrs = [self.nodes[0].getnewaddress(), self.nodes[0].getnewaddress()] | ||
| singletxid = self.nodes[0].sendtoaddress(chain_addrs[0], self.nodes[0].getbalance(), "", "", True) | ||
| singletxid = self.nodes[0].sendall(recipients=[chain_addrs[0]])['txid'] |
There was a problem hiding this comment.
In 923d245 I think that this change can be removed as it is modified in the next commit anyways?
|
ACK 28ea4c7 |
w0xlt
approved these changes
Aug 30, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 1, 2022
28ea4c7 test: simplify splitment with `sendall` in wallet_basic (brunoerg) 923d245 test: use `sendall` when emptying wallet (brunoerg) Pull request description: In some tests they have used `sendtoaddress` in order to empty a wallet. With the addition of `sendall`, it makes sense to use it for that. ACKs for top commit: achow101: ACK 28ea4c7 ishaanam: utACK 28ea4c7 w0xlt: ACK bitcoin@28ea4c7 Tree-SHA512: 903136d7df5c65d3c02310d5a84241c9fd11070f69d932b4e188b8ad45c38ab5bc1bd5a9242b3e52d2576665ead14be0a03971a9ad8c00431fed442eba4ca48f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some tests they have used
sendtoaddressin order to empty a wallet. With the addition ofsendall, it makes sense to use it for that.