mapport: require miniupnpc API version 17 or later

[fanquake]

Version 17 is currently the latest version, see: https://github.com/miniupnp/miniupnp/blob/master/miniupnpc/apiversions.txt, and has been available since the release of 2.1. 2.1 or newer is readily available across all distros, see https://repology.org/project/miniupnpc/versions, so drop support for the older API versions.

Split out of #22644.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto, TheCharlatan
Concept ACK	dergoegge

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #22644 (Deprecate UPnP support, require 2.1 or later by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[dergoegge]

Concept ACK

[hebasto]

Concept ACK.

[hebasto]

Now we can use PKG_CHECK_MODULES instead of

bitcoin/configure.ac

Lines 1414 to 1418 in 7753efc

	AC_CHECK_HEADERS(
	[miniupnpc/miniupnpc.h miniupnpc/upnpcommands.h miniupnpc/upnperrors.h],
	[AC_CHECK_LIB([miniupnpc], [upnpDiscover], [MINIUPNPC_LIBS="$MINIUPNPC_LIBS -lminiupnpc"], [have_miniupnpc=no], [$MINIUPNPC_LIBS])],
	[have_miniupnpc=no]
	)

as pkgconfig/miniupnpc.pc is being provided with a newer libminiupnpc-dev package across of all major distros and macOS's Homebrew.

[fanquake]

Now we can use PKG_CHECK_MODULES instead of

That doesn't quite work. But is already part of #22644 in any case.

[hebasto]

Now we can use PKG_CHECK_MODULES instead of

That doesn't quite work.

I'm not sure what it means, but my point is that using PKG_CHECK_MODULES makes the MINIUPNPC_API_VERSION check redundant.

[fanquake]

I'm not sure what it means,

You can't use it, because it's not supported for mingw-w64 builds using 2.1. So while we could patch depends, distro/self-builds would be broken.

[hebasto]

ACK b3b673f, tested on Ubuntu 20.04 w/ and w/o libminiupnpc-dev package.

[TheCharlatan]

ACK b3b673f

Tested against miniupnpc version 2.0 (API version 16) and it failed as expected. Also tested against system libminiupnpc-dev on Ubuntu 22.04.