Skip to content

doc: Fix typo in build-unix.md #30744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2024
Merged

doc: Fix typo in build-unix.md #30744

merged 1 commit into from
Aug 29, 2024

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Aug 28, 2024

Addresses #30454 (comment).

@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 28, 2024 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK l0rinc, davidgumberg, tdb3

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Docs label Aug 28, 2024
@hebasto hebasto mentioned this pull request Aug 28, 2024
Merged
l0rinc
l0rinc approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@l0rinc l0rinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e78551b

@davidgumberg
Copy link
Contributor

ACK e78551b

tdb3
tdb3 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@tdb3 tdb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e78551b

Received the warning before this fix. Warning gone after the fix.

CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_CC_COMPILER

@fanquake fanquake merged commit 4ae3be7 into bitcoin:master Aug 29, 2024
@hebasto hebasto deleted the 240828-typo branch August 29, 2024 09:32
@bitcoin bitcoin locked and limited conversation to collaborators Aug 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@l0rinc l0rinc l0rinc approved these changes

@tdb3 tdb3 tdb3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

No open projects
CMake
Status: CMake follow-ups

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hebasto @DrahtBot @davidgumberg @l0rinc @tdb3 @fanquake