Skip to content

make -logtimestamps default on and rework help-message #3188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2013
Merged

make -logtimestamps default on and rework help-message #3188

merged 1 commit into from
Nov 4, 2013

Conversation

Diapolo
Copy link

@Diapolo Diapolo commented Oct 30, 2013

It's IMHO much easier to work with debug.log, if timestamps are shown, which I think @sipa also mentioned some days ago.

@wtogami
Copy link
Contributor

wtogami commented Oct 31, 2013

ACK

1 similar comment
@petertodd
Copy link
Contributor

ACK

@sipa
Copy link
Member

sipa commented Nov 2, 2013

ACK, though I'd go further and remove -logtimestamps entirely.

Rebase please.

@Diapolo
Copy link
Author

Diapolo commented Nov 2, 2013

Rebased...

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/959e62f0c889788e7775d5953668ce0cc5c1fea8 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@mikehearn
Copy link
Contributor

As an interesting bit of history, IIRC the reason they were off by default is that Satoshi had a paranoia attack and was worried about someone gathering logs from lots of nodes to correlate timestamps. In a world where intelligence agencies tap major fibre backbones and other people simply connect to every node and time relays, it seems clear to me that the value of having more useful logs massively outweighs that concern.

@sipa
Copy link
Member

sipa commented Nov 3, 2013

Agree with @mikehearn here.

@laanwj
Copy link
Member

laanwj commented Nov 3, 2013

ACK

laanwj added a commit that referenced this pull request Nov 4, 2013
@laanwj
Merge pull request #3188 from Diapolo/logtimestamp_def
c4f2a00 
make -logtimestamps default on and rework help-message
@laanwj laanwj merged commit c4f2a00 into bitcoin:master Nov 4, 2013
@Diapolo Diapolo deleted the logtimestamp_def branch November 4, 2013 14:19
@pooler pooler mentioned this pull request Nov 5, 2013
Merged
Bushstar pushed a commit to Bushstar/omnicore that referenced this pull request Apr 8, 2020
@nmarley @UdjinM6
Detect masternode mode from masternodeblsprivkey arg (bitcoin#3188)
70b320b 
* Detect masternode mode from privkey arg

The `masternode` argument seems redundant. This change enables masternode mode
based on the presence (and validity) of the `masternodeblsprivkey` argument.

* Deprecate -masternode option

* Remove -masternode switch from functional tests

* Move -masternode deprecate warning to better place
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Diapolo @wtogami @petertodd @sipa @BitcoinPullTester @mikehearn @laanwj