. #33834
Closed
. #33834
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace explicit boolean comparisons with idiomatic C++ boolean evaluation. Changes: - Replace 'clusterset.m_oversized == true' with 'clusterset.m_oversized' (6 instances) - Replace 'clusterset.m_oversized == false' with '!clusterset.m_oversized' (3 instances) This improves code readability while maintaining exact semantic equivalence. All modifications are within conditional statements checking the m_oversized member variable. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33834. ReviewsSee the guideline for information on the review process. |
l0rinc
reviewed
Nov 9, 2025
| // a formerly-oversized main graph while staging exists (to satisfy chunk feerate | ||
| // queries into main, for example), and such merges could conflict with pulls of | ||
| // some of their constituents into staging. | ||
| if (level == GetTopLevel() && clusterset.m_oversized == true) { |
Contributor
There was a problem hiding this comment.
NACK, m_oversized is an std::optional<bool>
Contributor
|
Refactors are usually appreciated if they're a precursor to a bigger change with a generally desired outcome. |
achow101
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.