Skip to content

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Dec 8, 2025

"tor" as a network specification was deprecated in 60dc8e4 in favor of "onion"
and this commit removes it and updates the relevant test.

Previously #16029. This has been warning as being deprecated since v0.17.0.

"tor" as a network specification was deprecated in 60dc8e4 in favor
of "onion" and this commit removes it and updates the relevant test.
@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 8, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34031.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK pablomartin4btc, sipa

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

Copy link
Member

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7efb18c

Copy link
Member

@sipa sipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7efb18c

14 major releases ought to be a long enough deprecation period.

@fanquake
Copy link
Member Author

fanquake commented Dec 8, 2025

cc @laanwj

@fanquake fanquake changed the title netbase: Remove "tor" as a network specification net: Remove "tor" as a network specification Dec 8, 2025
@DrahtBot DrahtBot added the P2P label Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants