-
Notifications
You must be signed in to change notification settings - Fork 38k
Trivial: Correct spelling mistakes in doc folder #6843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MitchellCash
commented
Oct 17, 2015
- OSX —> OS X
- XCode —> Xcode
- github —> GitHub
- homebrew —> Homebrew
- gitian —> Gitian
- Other miscellaneous obvious spelling fixes and whitespace removal
ACK spelling changes, although I'd tend to NACK whitespace changes. Looks like some you're just deleting the trailing newline from files? For anyone who isn't aware, use ?w=1 to view the diff without whitespace. |
Thanks @fanquake I am reducing any double trailing newlines to a single trailing newline for consistency. Pending others thoughts I can revert this to spelling changes only. |
ACK |
doc/release-process.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're fixing doc spelling errors, please also fix this. Should be gbuild. Meant to do it myself, but haven't gotten around to it, and it would fit nicely in with this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good pick up @Michagogo I have squashed this change back into the original commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
On Saturday, October 17, 2015, Mitchell Cash notifications@github.com
wrote:
In doc/release-process.md
#6843 (comment):make -C ../bitcoin/depends download SOURCES_PATH=`pwd`/cache/common
Only missing files will be fetched, so this is safe to re-run for each build.
-NOTE: Offline builds must use the --url flag to ensure gitian fetches only from local URLs. For example:
+NOTE: Offline builds must use the --url flag to ensure Gitian fetches only from local URLs. For example:./bin/bguild --url bitcoin=/path/to/bitcoin,signature=/path/to/sigs {rest of arguments}
Good pick up @Michagogo https://github.com/Michagogo I have squashed
this change back into the original commit.—
Reply to this email directly or view it on GitHub
https://github.com/bitcoin/bitcoin/pull/6843/files#r42313888.
- OSX —> OS X - XCode —> Xcode - github —> GitHub - homebrew —> Homebrew - gitian —> Gitian - Other miscellaneous obvious spelling fixes and whitespace removal
1873ea4
to
99963b9
Compare
ACK 99963b9 |
99963b9 Correct spelling mistakes in doc folder (Mitchell Cash)