Skip to content

Conversation

MitchellCash
Copy link
Contributor

  • OSX —> OS X
  • XCode —> Xcode
  • github —> GitHub
  • homebrew —> Homebrew
  • gitian —> Gitian
  • Other miscellaneous obvious spelling fixes and whitespace removal

@fanquake
Copy link
Member

ACK spelling changes, although I'd tend to NACK whitespace changes. Looks like some you're just deleting the trailing newline from files?

For anyone who isn't aware, use ?w=1 to view the diff without whitespace.

@MitchellCash
Copy link
Contributor Author

Thanks @fanquake I am reducing any double trailing newlines to a single trailing newline for consistency. Pending others thoughts I can revert this to spelling changes only.

@btcdrak
Copy link
Contributor

btcdrak commented Oct 17, 2015

ACK

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're fixing doc spelling errors, please also fix this. Should be gbuild. Meant to do it myself, but haven't gotten around to it, and it would fit nicely in with this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pick up @Michagogo I have squashed this change back into the original commit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

On Saturday, October 17, 2015, Mitchell Cash notifications@github.com
wrote:

In doc/release-process.md
#6843 (comment):

make -C ../bitcoin/depends download SOURCES_PATH=`pwd`/cache/common

Only missing files will be fetched, so this is safe to re-run for each build.

-NOTE: Offline builds must use the --url flag to ensure gitian fetches only from local URLs. For example:
+NOTE: Offline builds must use the --url flag to ensure Gitian fetches only from local URLs. For example:

 ./bin/bguild --url bitcoin=/path/to/bitcoin,signature=/path/to/sigs {rest of arguments}

Good pick up @Michagogo https://github.com/Michagogo I have squashed
this change back into the original commit.


Reply to this email directly or view it on GitHub
https://github.com/bitcoin/bitcoin/pull/6843/files#r42313888.

- OSX —> OS X
- XCode —> Xcode
- github —> GitHub
- homebrew —> Homebrew
- gitian —> Gitian
- Other miscellaneous obvious spelling fixes and whitespace removal
@maflcko
Copy link
Member

maflcko commented Oct 18, 2015

ACK 99963b9

@laanwj laanwj added the Docs label Oct 19, 2015
@laanwj laanwj merged commit 99963b9 into bitcoin:master Oct 19, 2015
laanwj added a commit that referenced this pull request Oct 19, 2015
99963b9 Correct spelling mistakes in doc folder (Mitchell Cash)
@MitchellCash MitchellCash deleted the spelling_fixes branch October 20, 2015 09:57
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants