Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Apr 8, 2016

adding CNode::fRelayTxes to getnetworkinfo under the name of localrelay (bool)

updated pull #7839
#7771

dragongem45 added 4 commits April 8, 2016 13:43
…tworkinfo

adding CNode::fRelayTxes to getnetworkinfo under the name of localrelay (bool)
adding GetfRelayTxes
@ghost
Copy link
Author

ghost commented Apr 8, 2016

a new fix has been applyed to this code

@sipa
Copy link
Member

sipa commented Apr 8, 2016

@dragongem45 If you find more things to fix in the future, you can just force push to the github branch associated with it, you don't need to close and open a new pull request.

@ghost
Copy link
Author

ghost commented Apr 8, 2016

is there a way to restart travis-ci biulds

@sipa
Copy link
Member

sipa commented Apr 8, 2016

@dragongem45 Yes, by pushing a new commit.

@ghost
Copy link
Author

ghost commented Apr 8, 2016

do you have any ideas on what i am doing wrong

@sipa
Copy link
Member

sipa commented Apr 8, 2016

See https://travis-ci.org/bitcoin/bitcoin/jobs/121714563

In file included from main.h:16:0,
                 from checkpoints.cpp:9:
net.h: In static member function ‘static bool CNode::GetfRelayTxes()’:
net.h:360:10: error: invalid use of member ‘CNode::fRelayTxes’ in static member function
net.h:362:16: error: from this location

Can you try compiling your own code before submitting a patch?

@ghost
Copy link
Author

ghost commented Apr 8, 2016

ok i wil form this message here thanks for the tips

@maflcko
Copy link
Member

maflcko commented Apr 8, 2016

@dragongem45 Please build and test your changes locally. Also make sure to squash the commits using git locally. If there are any issues we can help you in the IRC.

@ghost
Copy link
Author

ghost commented Apr 8, 2016

sorry its a part of my IDE i'm going to disable it.
just today it seems like all my code breaks

@ghost
Copy link
Author

ghost commented Apr 8, 2016

compile worked. now there is a python test error

UdjinM6 pushed a commit to dashpay/dash that referenced this pull request Jul 21, 2017
…elay is enabled in `getnetwork` (#1545)

* net: Add fRelayTxes flag

Add a fRelayTxes to keep track of the relay transaction flag
we send to other peers.

* rpc: Add `relaytxes` flag to `getnetworkinfo`

Re-work of PR bitcoin#7841 by dragongem45.
Closes bitcoin#7771.
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Jan 5, 2018
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants