New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qa] Remove hardcoded "4 nodes" from test_framework #8056

Merged
merged 2 commits into from May 20, 2016

Conversation

Projects
None yet
4 participants
@MarcoFalke
Member

MarcoFalke commented May 15, 2016

This is the first pull of two to remove the hardcoded 4 nodes from test_framework.py. This includes several benefits, which come for free:

  • Each derived test can now set the number of nodes in __init__() and have the base class deal with setting up the network. This makes the test easier to read and easier for newcomers to get started writing tests, hopefully.
  • Also, __init__() is used to specify if the chain should be clean (default=False), instead of calling the util function directly.
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 15, 2016

Member

Added a commit to reduce the node count for some tests.

Member

MarcoFalke commented May 15, 2016

Added a commit to reduce the node count for some tests.

@btcdrak

This comment has been minimized.

Show comment
Hide comment
@btcdrak
Member

btcdrak commented May 15, 2016

utACK fad68f7

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 18, 2016

Member

ut/Concept ACK fad68f7

Member

laanwj commented May 18, 2016

ut/Concept ACK fad68f7

@@ -8,25 +8,31 @@
#
from test_framework.test_framework import BitcoinTestFramework
from test_framework.util import *
from test_framework.util import str_to_b64str, assert_equal

This comment has been minimized.

@jtimon

jtimon May 20, 2016

Member

Nice, explicit is better than implicit.

@jtimon

jtimon May 20, 2016

Member

Nice, explicit is better than implicit.

@jtimon

This comment has been minimized.

Show comment
Hide comment
@jtimon

jtimon May 20, 2016

Member

utACK fad68f7

Member

jtimon commented May 20, 2016

utACK fad68f7

@MarcoFalke MarcoFalke merged commit fad68f7 into bitcoin:master May 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request May 20, 2016

Merge #8056: [qa] Remove hardcoded "4 nodes" from test_framework
fad68f7 [qa] Reduce node count for some tests (MarcoFalke)
fac9349 [qa] Remove hardcoded "4 nodes" from test_framework (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1605-qaFlex branch May 20, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8056: [qa] Remove hardcoded "4 nodes" from test_framework
fad68f7 [qa] Reduce node count for some tests (MarcoFalke)
fac9349 [qa] Remove hardcoded "4 nodes" from test_framework (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8056: [qa] Remove hardcoded "4 nodes" from test_framework
fad68f7 [qa] Reduce node count for some tests (MarcoFalke)
fac9349 [qa] Remove hardcoded "4 nodes" from test_framework (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 21, 2017

Merge #8056: [qa] Remove hardcoded "4 nodes" from test_framework
fad68f7 [qa] Reduce node count for some tests (MarcoFalke)
fac9349 [qa] Remove hardcoded "4 nodes" from test_framework (MarcoFalke)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment