Skip to content

Conversation

jl2012
Copy link
Contributor

@jl2012 jl2012 commented Oct 18, 2016

No description provided.

@fanquake
Copy link
Member

utACK 9b0d8ef, the test failure is unrelated.

..........
p2p-compactblocks.py:
...snip...
Failed
stderr:
  File "/home/travis/build/bitcoin/bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 148, in main
    self.run_test()
  File "/home/travis/build/bitcoin/bitcoin/build/../qa/rpc-tests/p2p-compactblocks.py", line 809, in run_test
    sync_blocks(self.nodes)
  File "/home/travis/build/bitcoin/bitcoin/qa/rpc-tests/test_framework/util.py", line 138, in sync_blocks
    raise AssertionError("Block sync failed")
Pass: False, Duration: 100 s

@jonasschnelli
Copy link
Contributor

utACK
@jl2012 maybe post a signature done with your old key here for consistency?

@maflcko
Copy link
Member

maflcko commented Oct 18, 2016

So what happened to the old key?

$ gpg --fingerprint jl2012
pub   4096R/B3936517 2015-10-16
      Key fingerprint = D3CC 1772 8600 5BB8 FF67  3294 C524 2A1A B393 6517

@maflcko
Copy link
Member

maflcko commented Oct 18, 2016

Concept NACK from me. This is the same key, it seems.

@jl2012
Copy link
Contributor Author

jl2012 commented Oct 18, 2016

@MarcoFalke The self-signature of the key was expired in August. This one has the new signature

@laanwj
Copy link
Member

laanwj commented Oct 18, 2016

At some point it was decided not to update keys in this repository unless the actual key changed, to minimize diff noise (see e.g. discussion in #8547).

People are however advised to run gpg --refresh-keys after importing: #8603

@jl2012
Copy link
Contributor Author

jl2012 commented Oct 18, 2016

OK, closing

@jl2012 jl2012 closed this Oct 18, 2016
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Dec 2, 2016
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Nov 9, 2018
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants