change address in send dialog is ignored if its private key is unknown

[dooglus]

If I try to send change to an address in a different wallet, I see the message "Warning: Unknown change address" and the change is sent to a new address in the current wallet. There is no indication my request to use a specific change address is being ignored.

See this reddit post for an example of this behavior confusing a user.

I think it would be better to use the provided address whether or not the private key is available, so long as the warning is provided when we don't know the private key.

[fanquake]

Copying in the Reddit comment and images:

"""
Can someone please explain what is happening here?
Note: Everything done on testnet so the only value lost was time.
In this first screenshot:

it shows that:
1 I am making a payment to mwCwTceJvYV27KXBc3NJZys6CjsgsoeHmf
2 I am sending change to mogwtVo5bDzJRWsVNLEpfDDt5dXHcC2tf5 <- cold wallet address.
The second screenshot shows extra translation fees being calculated:

The third screenshot shows the change going to a completely different address, change went to n18wMXVBXoE134AQsd7GcQKnjBah2MsPdD

I have tested this twice, and twice the change went to an address other than the address I specified.
What's going on?
"""

[jonasschnelli]

A custom change address thats not part of the wallet can result in lost funds. We need to be careful.
But if one provides a non-wallet-owned change address, it should never fallback to an internal/different change address (without warning and accepting by the user).

If its not already the case (need to retest), we should warn significant but then accept the custom non-wallet-change address.

This is part of CoinControl and we can expect expert users here.

[sylvandb]

Using 13.0 on linux the only warning is "unknown change address" which to me does not inform that it will ignore my input and send instead to a new generated wallet change address. Which is what happens.

[dooglus]

@jonasschnelli

A custom change address thats not part of the wallet can result in lost funds

It is possible, for sure. But ignoring the provided change address and instead sending the change to a new address could also result in lost funds since the user will be expecting the change to be in the address he specified (in a different wallet) and may feel safe to delete the wallet.dat file because he thinks he has just emptied it.

[jonasschnelli]

Fixed by #9413

[sylvandb]

Hooray! Thank you! :)