Remove instantiable Address object #316
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Thoughts were to do |
Contributor
|
I thought the point of having |
dcousens
force-pushed
the
2.0.0
branch
6 times, most recently
from
f1e8442 to
2746027
Compare
Contributor
Author
|
@weilu would edit: Though I guess you're probably only ever going to need one or the other. |
dcousens
force-pushed
the
2.0.0
branch
2 times, most recently
from
093e8f8 to
c536926
Compare
Contributor
|
Yeah, base58 was my thought |
Contributor
Author
|
Ok, will rebase, update then notify |
dcousens
force-pushed
the
2.0.0
branch
2 times, most recently
from
b9dc89b to
5db6e34
Compare
dcousens
force-pushed
the
2.0.0
branch
2 times, most recently
from
eddb9c4 to
4bca4b0
Compare
dcousens
force-pushed
the
2.0.0
branch
4 times, most recently
from
cb3c291 to
4668cb1
Compare
crypto: use packages directly
add a note about uglying (to avoid issues with typeForce)
Thanks @jprichardson for the suggestion
… alternative network
Updated Copyright Date
bufferutils: remove equal, use Buffer.compare
Add Example on Generating a Random Address and WIF for Alternative Network
Contributor
Author
|
Will re-open as this now meant to be merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted for 2.0.0.
This is a continued discussion of #306 which was closed due to the 3.0.0 branch being deleted.