feat(cli): rename localnet clean to remove, keep clean as alias - #227
Merged
Conversation
`remove` names the destructive teardown action plainly and reads unambiguously next to the other lifecycle verbs (down, stop, remove), where "clean" could be mistaken for a non-destructive tidy-up. The `clean` alias is retained so existing scripts, CI pipelines, and muscle memory keep working without a breaking change. - clean.go: Use "remove", Aliases ["clean"]; flag/help wording updated - help.go + help_test.go: advertise "remove" in --help - telemetry allowlist: add "remove" verb (canonical CommandPath), keep "clean" so historical counters stay valid - cli_test.go: assert both remove and the clean alias require a target - skills docs: ci-localnet / lifecycle use "remove" (skills-lint resolves canonical Name(), not aliases) - docs, CI examples, down.go hint, Web UI copy, mockups: use "remove" - changes-from-proposal.md: record the clean -> remove rename + alias
zheli
force-pushed
the
add-clean-alias-remove
branch
from
July 7, 2026 19:00
3094bf4 to
afa2029
Compare
The command was renamed clean -> remove; align the source filenames (internal/cli/localnet and internal/localnet, plus its test) so the file names match the canonical command. Pure file rename — symbols and behaviour are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes
removethe canonical name for the destructive LocalNet teardown command, withcleanretained as a backward-compatible alias.dpm localnet removeanddpm localnet cleanare equivalent; flags are unchanged (--name,--all,--force,--dry-run).Why
removenames the action plainly and reads unambiguously next to the other lifecycle verbs (down,stop,remove), where "clean" could be mistaken for a non-destructive tidy-up. Keepingcleanas an alias means existing scripts, CI pipelines, and muscle memory keep working with no breaking change.Changes
internal/cli/localnet/clean.go:Use: "remove",Aliases: ["clean"]; flag/help wording updated.internal/cli/help.go(+help_test.go):--helpadvertisesremove.internal/telemetry/allowlist.go: addremovetocommandVerbs(telemetry records the canonicalCommandPath()verb);cleankept so historical counters stay valid.internal/cli/cli_test.go: asserts bothremoveand thecleanalias require a target.internal/skills/docs/{ci-localnet,localnet-lifecycle}.md): useremove— the skills-lint test resolves the canonicalName(), not aliases, so executable examples must useremove.localnet-lifecycle,observability,dashboard-customization), CI examples,down.gohint, Web UI copy, and design mockups: useremove(noting thecleanalias where user-facing).docs/changes-from-proposal.md: records theclean→removerename + the new alias (required by AGENTS.md proposal-deviation tracking).Notes
docs/tests/*left unchanged — historical test records, out of grant-facing scope and not linted.website/guide pages are auto-generated fromdocs/at build time (sync-docs), so no manual website edits are needed.Verification
make lint— 0 issuesmake test— all packages passlocalnet --helplistsremove;localnet remove --helpshowsAliases: clean;localnet cleanstill dispatches.