refactor(cli): finish clean->remove rename and accept positional name - #229
Merged
Conversation
Complete the clean -> remove rename by renaming all Clean/clean symbols and comments to Remove/remove, and make the remove command accept the instance name positionally (localnet remove <name>) like the other lifecycle verbs, while keeping --name for backward compatibility and --all mutually exclusive with naming a single instance.
zheli
force-pushed
the
add-clean-alias-remove
branch
from
July 8, 2026 07:17
07b54a1 to
8a8ae19
Compare
2 tasks
zheli
added a commit
that referenced
this pull request
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #227 (merged), which renamed the
localnet cleancommand toremove(keepingcleanas an alias). This PR completes the rename and improves the UX.What changed
Clean/cleansymbols, doc comments, and user-facing strings toRemove/removeacrossinternal/localnet,internal/docker,internal/registry,internal/splice, andinternal/cli/localnet.localnet remove <name>now accepts the instance name as a positional argument (mirroringup/down/stop/start).--nameis still accepted for backward compatibility; passing both is an error, and--allremains mutually exclusive with naming a single instance.removetonoticeOperationalVerbs(keptcleansince the notice gate reads the raw typed token).docs/changes-from-proposal.mddocuments the positional-name behavior change.Verification
go build ./...,make lint(0 issues),make testall green (including skills-lint).