Skip to content

Cache CultureInfoManager default and supported cultures #12761 - #12762

Merged
yasmoradi merged 1 commit into
bitfoundation:developfrom
yasmoradi:perf/12761-cache-cultureinfomanager-cultures
Jul 22, 2026
Merged

Cache CultureInfoManager default and supported cultures #12761#12762
yasmoradi merged 1 commit into
bitfoundation:developfrom
yasmoradi:perf/12761-cache-cultureinfomanager-cultures

Conversation

@yasmoradi

Copy link
Copy Markdown
Member

Summary

Caches the default and supported cultures so they are built once instead of on every access.

Changes

  • CultureInfoManager: back DefaultCulture and SupportedCultures with the field keyword (field ??= ...) so they are computed lazily and cached for the app lifetime.

Related Issue

This closes #12761

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@yasmoradi, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 07f5499c-690d-4374-9881-4aa75c8e038f

📥 Commits

Reviewing files that changed from the base of the PR and between 4bc0aea and 176fcb3.

📒 Files selected for processing (1)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Infrastructure/Services/CultureInfoManager.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yasmoradi
yasmoradi merged commit d6cfbf9 into bitfoundation:develop Jul 22, 2026
3 checks passed
@yasmoradi
yasmoradi deleted the perf/12761-cache-cultureinfomanager-cultures branch July 22, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CultureInfoManager rebuilds default and supported CultureInfo lists on every access

1 participant